Re: [PATCH net v3 05/14] net: pse-pd: do not reach a freed PHY from the notification worker

From: Carlo Szelinsky

Date: Thu Nov 05 2026 - 13:02:40 EST


On Thu, 05 Nov 2026 10:08:32 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Could the struct doc and the pse_control_get_netdev() doc mention the
> locking requirement and the shared-PI NULL case?

Yes. In v4 the rule moves into the kernel-doc, and the comment in the
worker gets shorter, as Kory asked.

> This is a pre-existing issue, but is the net_device itself still left
> unprotected here?

Yes, the worker holds no reference on the net_device. This was the
same before the patch, which only fixes the phy_device part. I keep it
for a separate fix.

Carlo