Re: [PATCH 4/8] pwm: axi-pwmgen: Enable clocks before accessing hardware registers in probe()

From: Lee Jones

Date: Thu Nov 05 2026 - 13:27:25 EST


On Thu, 05 Nov 2026, Lee Jones wrote:

> On Thu, 05 Nov 2026, Uwe Kleine-König wrote:
>
> > On Thu, Nov 05, 2026 at 02:38:06PM +0000, Lee Jones wrote:
> > > axi_pwmgen_probe() calls axi_pwmgen_setup(), which reads and writes MMIO
> > > registers to verify the IP core version and determine the channel count,
> > > before acquiring and enabling axi_clk. If the bootloader leaves the AXI
> > > peripheral clock gated, accessing the registers causes an unclocked bus
> > > access fault.
> >
> > Do you have the hardware? Or what convinced you that an access fault
> > happens?
>
> These are Sashiko bugs, as we discussed out-of-band.
>
> None of these have been tested on real h/w.

I'll make that clear in the cover-letters going forward.

--
Lee Jones