Re: [PATCH net-next] net/mlx4: drop the unused is_supported callback

[Tariq Toukan]

On 03/11/2026 14:21, Peter Morrow wrote:
> Since commit 557d80138618 ("net/mlx4: always create the eth and ib
> auxiliary devices"), both is_supported callbacks return true, so the
> checks in add_drivers() and delete_drivers() no longer decide
> anything. Drop the callbacks and keep the aux device table as an array
> of suffixes.
>
> Tested with this change applied to 6.12.113 on an Azure VM with two
> ConnectX-3 VFs: both auxiliary devices are created at boot, and
> removing mlx4_ib, mlx4_en and mlx4_core deletes them cleanly.
>
> Suggested-by: Simon Horman <horms@xxxxxxxxxx>
> Signed-off-by: Peter Morrow <pdmorrow@xxxxxxxxx>
> ---
>   drivers/net/ethernet/mellanox/mlx4/intf.c | 44 ++++-------------------
>   1 file changed, 6 insertions(+), 38 deletions(-)
Thanks for the cleanup.

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>