Re: [PATCH] ASoC: cs42l43: leak MCLK when PLL enable fails on PRE_PMU

[Tang Bin]

Hi Charles,

Thanks for the review and pointing this out. 

On Wed, Nov 04, 2026 at 11:04:26AM +0000, Charles Keepax wrote:
> Could you point to the relevant bits of the core code here? My
> understanding is that DAPM mostly just carrys on in the case of
> an error from an event handler, so I would not expect the
> sequence to play out as you describe.

You are absolutely right. I dug into dapm_seq_check_event() in soc-dapm.c. 
As you noted, if the event handler returns an error, DAPM only logs it 
(via dev_err) but continues the power-up sequence. 

Therefore, the widget is still marked as powered, and the matching POST_PMD 
will indeed run and execute clk_disable_unprepare(mclk) as expected. There 
is no reference count leak here.

My initial premise was incorrect. Please drop this patch.

Best regards,
Tang Bin