RE: [PATCH 07/10] pinctrl: realtek: Initialise omitted offset fields to NA in config macros

[Yu-Chun Lin [林祐君]]

> On Tue, Nov 3, 2026 at 10:31 PM Lee Jones <lee@xxxxxxxxxx> wrote:
> 
> > The Realtek pinctrl driver uses NA (0xffffffff) as the sentinel for
> > unsupported pin configuration features.  However, RTK_PIN_CONFIG omits
> > input_volt_offset, slew_rate_offset, and hvil_offset, and
> > RTK_PIN_CONFIG_V2 omits slew_rate_offset and hvil_offset.  Because C99
> > designated initialisers zero-initialise omitted members, those fields
> > default to 0 instead of NA, causing rtd_pconf_parse_conf() to treat
> > unsupported features as valid at bit offset base_bit + 0 and corrupt
> > adjacent register bits.
> >
> > Explicitly initialise the omitted offset fields to NA in
> > RTK_PIN_CONFIG and RTK_PIN_CONFIG_V2.
> >
> > Fixes: dcc9334435b0 ("pinctrl: realtek: add support for slew rate,
> > input voltage and high VIL")
> > Fixes: e309dbd523b8 ("pinctrl: realtek: add rtd1625 pinctrl driver")
> > Closes:
> > https://sashiko.dev/#/bug/linux-fbd0bf54-6dba-4652-9418-270b11fb6d8b
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
> 
> This patch 7/10 applied to the pinctrl tree for fixes.
> 
> Yours,
> Linus Walleij

Hi Linus,

Thanks for applying this patch. Just a quick heads-up on the merged commit [1]:

1. The first Fixes tag kept the original 'dcc9334435b0' instead of the corrected
'e99ce78030db' I suggested.
2. Branch: It was applied to 'for-next' instead of 'fixes'. Just checking if
this was intended.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=for-next&id=0e62a6aadef5bf93a379ac7aa9a89f43596f83e4

Best regards,
Yu-Chun