Re: [PATCH v7 1/2] nvme: add per-queue sysfs directories

[Saravanan D]

On Wed, Nov 04, 2026 at 06:30:56PM +0100, Daniel Wagner wrote:
> > +	ret = sysfs_create_groups(&qinfo->kobj, ctrl->ops->queue_attr_groups);
> > +	if (ret)
> > +		goto out_put;
>
> Don't you have to call kobject_del(&qinfo->kobj); here?

Yes. Sashiko flagged the same error path.

I will send a v8 that adds an out_del label calling kobject_del()
before kobject_put(), so a failed sysfs_create_groups() unlinks the
<qid> directory before nvme_add_queue_info() returns.

Thanks for the review.

Saravanan D.