Re: [PATCH v1] perf jevents: Don't encode MSRs with no value
From: Namhyung Kim
Date: Fri Nov 06 2026 - 02:28:03 EST
On Wed, Nov 04, 2026 at 08:48:41PM -0800, Ian Rogers wrote:
> Fixes the events mem_trans_retired.load_latency (EMR) and
> mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having
> their ldlat= value encoded as python's None.
>
> Fixes: ffc606ada3d7 ("perf jevents: Add python converter script")
> Reported-by: kernel test robot <yi1.lai@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-lkp/202611050801.67bb4af4-lkp@xxxxxxxxx
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
Arnaldo, I think it's good to go to v7.4.
Thanks,
Namhyung
> ---
> tools/perf/pmu-events/jevents.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 080e04b51b8c..e083f7495e67 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
> @@ -396,7 +396,7 @@ class JsonEvent:
> event += f',{value}{canonicalize_value(jd[key])}'
> if filter:
> event += f',{filter}'
> - if msr:
> + if msr and msrval:
> event += f',{msr}{msrval}'
> if self.desc and extra_desc:
> self.desc += extra_desc
> --
> 2.56.0.455.g6c5a503b38-goog
>