Re: [PATCH v2 0/5] Update maintainer-pgp-guide.rst Chinese translation
From: Weijie Yuan
Date: Fri Nov 06 2026 - 03:07:54 EST
Dongliang Mu <dzm91@xxxxxxxxxxx> writes:
>
> On 8/23/26 3:14 PM, Weijie Yuan wrote:
> > The script says:
> >
> > $ tools/docs/checktransupdate.py Documentation/translations/zh_CN/process/maintainer-pgp-guide.rst
> > [1787244823.341547] Documentation/translations/zh_CN/process/maintainer-pgp-guide.rst
> > [1787244823.630509] commit 54857c52452a ("docs: maintainer-pgp-guide.rst: add a reference for kernel.org sign")
> > [1787244823.680849] commit 6c5c07bc8589 ("docs: process: maintainer-pgp-guide: update kernel.org docs link")
> > [1787244823.730027] commit 273aa250f138 ("Documentation: Improve wording on requirements for a free Nitrokey")
> > [1787244823.779408] commit f44a29784f68 ("Documentation: update maintainer-pgp-guide for latest best practices")
> > [1787244823.779522] 4 commits needs resolving in total
> >
> > So I updated this document in chronological order, created four patches
> > based on these four outdated commits to make it easier for you to
> > review. Hence, you can freely squash them when applying them.
>
> I am not sure if we should use "So I updated XXX" in the cover letter
> message.
>
> From my understanding, it is fine to describe about what you have done and
> why you do this here.
Fine, will notice this.
> > Tested with make cleandocs && make htmldocs, no warning or error made by
> > these patches. (Hope my eyes work fine this time :))
>
> Haha, LLM can help here.
Ah yes.
> > [+To: Konstantin, as he is the original author, thanks.]
>
> Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
Thanks.
[...]
> > Range-diff versus v1:
>
> I think this versus is too long to read and it has no much information. In
> the future please do not add such thing in your patches.
Yes, indeed. In our literary work, range-diff may be not that useful
compared with actual codes reviews. So it would be better to just look
at the patch content directly, not range-diff.
Will pay attention this and save our time.
Thanks.