Re: [PATCH v5 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC

[H. Nikolaus Schaller]

> Am 06.11.2026 um 08:05 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
> 
> On 05/11/2026 22:32, Olivier Louvignes wrote:
>> The X1600's SAR ADC has four auxiliary channels and none of the
>> touchscreen or battery engines of the JZ47xx ADCs in ingenic,adc.yaml,
>> so it gets a binding of its own.
>> 
>> Signed-off-by: Olivier Louvignes <olivier@xxxxxxxxx>
>> Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> # LX16 - driver only, no real world test
> 
> Drop, did not happen. Even comment says it did not happen!

What did not happen? Are you expecting a software test or a full hardware test?

> 
> Otherwise please explain me how this code was executed on a device.

1. add decive tree entries, 2. compile, 3. install, 4. boot and load module, 5. check sysfs

root@letux-lx16v0-3:~# ls -l /sys/devices/platform/apb/10070000.sadc
total 0
lrwxrwxrwx 1 root root    0 Nov  6 08:00 driver -> ../../../../bus/platform/drivers/ingenic-x1600-adc
-rw-r--r-- 1 root root 4096 Nov  6 08:00 driver_override
drwxr-xr-x 3 root root    0 Nov  6 07:58 iio:device0
-r--r--r-- 1 root root 4096 Nov  6 08:00 modalias
lrwxrwxrwx 1 root root    0 Nov  6 08:00 of_node -> ../../../../firmware/devicetree/base/apb/sadc@10070000
drwxr-xr-x 2 root root    0 Nov  6 08:00 power
lrwxrwxrwx 1 root root    0 Nov  6 08:00 subsystem -> ../../../../bus/platform
-rw-r--r-- 1 root root 4096 Nov  6 08:00 uevent
root@letux-lx16v0-3:~# cat /sys/devices/platform/apb/10070000.sadc/iio\:device0/in_voltage*
1512
1793
1796
1798
0.805664062
root@letux-lx16v0-3:~# cat /sys/devices/platform/apb/10070000.sadc/iio\:device0/in_voltage*
1512
1760
1766
1773
0.805664062
root@letux-lx16v0-3:~# cat /sys/devices/platform/apb/10070000.sadc/iio\:device0/in_voltage*
1518
1767
1767
1776
0.805664062
root@letux-lx16v0-3:~# 

You can see that the values look reasonable and fluctuate a little by noise as you would
expect from an ADC with floating inputs.

But are you expecting a hardware test that the values are similar to the real voltages?
This is beyond my hardware capabilities.

Maybe you are more happy with:

Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> # LX16 - bindings and driver function only, no real electrical performance test

BR and have a good day,
Nikolaus