Re: [PATCH v8 1/7] dt-bindings: iio: imu: icm42600: Drop interrupt requirement
From: Krzysztof Kozlowski
Date: Fri Nov 06 2026 - 03:21:30 EST
On Thu, Nov 05, 2026 at 04:48:49PM +0100, Kanak Shilledar wrote:
> The devicetree documentation for the invensense,icm426xx devices was
> documented wrongly. As per the discussion in the thread[1], the IMUs can
> work in polling mode, making the interrupts as not required.
>
> Fix the dt-binding to not have interrupt property as mandatory. The
> driver will need to be fixed to not fail if interrupts are missing from
> the device tree. This will be done in a separate patch.
>
> Link: https://lore.kernel.org/linux-iio/20261018034134.2bf170a0@jic23-hlaptop/ [1]
> Fixes: 22addefdabdf ("dt-bindings: iio: imu: icm42600: Add icm42607")
> Change-Id: I91ec65f6c00cbd6a48273ccd8cc476ee5266b995
Your work is going to worse direction - quality decreases :/. This was
not here before.
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof