Re: [PATCH] cgroup: replace BUG_ON()s in compare_css_sets() with WARN_ON_ONCE()
From: Shaojie Sun
Date: Fri Nov 06 2026 - 04:52:22 EST
On Thu, Nov 05, 2026 at 05:52:29AM -1000, Tejun Heo wrote:
> Why are we changing this now? These never fired, and if they ever fire,
> we're in a very deep doodoo.
Agreed -- these checks never fire in practice, and if they ever do the
css_set bookkeeping is already inconsistent, so stopping right there is
better than limping on with a broken css_set. The BUG_ON()s are the
right thing here.
I'm withdrawing the patch. Thanks for taking a look.
--
Shaojie