Re: [PATCH v2 00/10] ASoC: fsl_sai: Address several issues in the driver

[Shengjiu Wang]

On Thu, Nov 5, 2026 at 6:43 PM <phucduc.bui@xxxxxxxxx> wrote:
>
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Hi all,
>
> I've continued reviewing the FSL SAI driver and referred to the
> i.MX RT1180 Reference Manual when looking into its register
> configurations and behavior:
>
> https://www.nxp.com/docs/en/reference-manual/IMXRT1180RM.pdf
>
> Link v1:
> https://lore.kernel.org/all/20261030091404.18757-1-phucduc.bui@xxxxxxxxx/
> Change in v2:
>  - Add five patches covering disable handling, documentation,
>    ISR error handling, BCLK ratio validation,
>    and preventing incorrect CHMOD writes to the other direction's xCR4.
>
> Compile-tested only.
>

The series looks good to me.

Reviewed-by: Shengjiu Wang <shengjiu.wang@xxxxxxxxx>

Best regards
Shengjiu Wang

> Best regards,
> Phuc
>
> bui duc phuc (10):
>   ASoC: fsl_sai: Fix PM QoS cleanup on resume failure
>   ASoC: fsl_sai: Use optional clock getter for MCLKs
>   ASoC: fsl_sai: Remove redundant error messages
>   ASoC: fsl_sai: Propagate device tree property read errors
>   ASoC: fsl_sai: Drop redundant dataline mask AND
>   ASoC: fsl_sai: Warn if TE/RE does not clear on disable
>   ASoC: fsl_sai: Clarify fsl_sai_dir_is_synced() documentation
>   ASoC: fsl_sai: Check regmap_read() return value in ISR
>   ASoC: fsl_sai: Reject bclk ratio smaller than slot width
>   ASoC: fsl_sai: Don't write CHMOD to the other direction's xCR4
>
>  sound/soc/fsl/fsl_sai.c | 89 +++++++++++++++++++++++------------------
>  1 file changed, 49 insertions(+), 40 deletions(-)
>
> --
> 2.43.0
>