Re: [PATCH v2 2/2] mfd: Use named initializers for acpi_device_id
From: Thomas Richard
Date: Fri Nov 06 2026 - 05:04:31 EST
On 11/4/26 5:09 PM, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
> Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Pawel Zalewski <pzalewski@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +-
> drivers/mfd/cs42l43-i2c.c | 8 ++++----
> drivers/mfd/intel_pmc_bxt.c | 2 +-
> drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +-
> drivers/mfd/intel_soc_pmic_chtdc_ti.c | 4 ++--
> drivers/mfd/intel_soc_pmic_chtwc.c | 2 +-
> drivers/mfd/intel_soc_pmic_crc.c | 4 ++--
> drivers/mfd/intel_soc_pmic_mrfld.c | 4 ++--
> drivers/mfd/kempld-core.c | 6 +++---
> drivers/mfd/loongson-se.c | 2 +-
> drivers/mfd/upboard-fpga.c | 6 +++---
Acked-by: Thomas Richard <thomas.richard@xxxxxxxxxxx> # upboard-fpga.c
Best Regards,
Thomas