Re: [PATCH v2 11/24] phy: zte: Add ZTE ZX279128S PCIe PHY driver
From: Agustin Santiago Isasmendi
Date: Fri Nov 06 2026 - 05:21:56 EST
Hi Navid,
On Wed, Oct 14, 2026 at 08:20:51AM +0100, Navid Ghahremani wrote:
> + if (i == 0 && port->has_cal) {
> + ret = regmap_write(zphy->regmap, CRM1_PHY1_CAL1, 0x00202d5a);
> + if (ret)
> + return ret;
> + ret = regmap_write(zphy->regmap, CRM1_PHY1_CAL0, 0x0046c24a);
On my unit both read back 0 after boot: there seems to be no register
at 0x1b0/0x1b4 in the top CRM. The vendor kernel writes these two
values into the port 1 controller's "ctrl" window instead
(0x09600000 + 0x1b4, then + 0x1b0); with this series those read
0x00203c78 / 0x0c46c24a. The link trains anyway (the MT7916 enumerates
at 2.5 GT/s), so it may only matter for signal margin, but as written
the writes have no effect.
Agustin