[PATCH v2] dt-bindings: media: amlogic,axg-ge2d: add S4 support

From: christian . koever-draxl

Date: Fri Nov 06 2026 - 05:22:20 EST


From: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>

Add a compatible for the S4 GE2D and allow a power domain, which the S4
block sits in.

The AXG GE2D is a special version that does not use the canvas to read
and write buffers, so the S4 one is not strictly compatible with it and
gets no fallback.

Only the S4 block sits in a power domain of its own, so require one
there and disallow it for AXG.

Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
---
Changes in v2:
- Separate compatible, no amlogic,axg-ge2d fallback: the AXG GE2D does
not use the canvas, so the two are not compatible (Neil).
- power-domains is required for amlogic,s4-ge2d and not allowed for
AXG, which has none (Krzysztof).
- Link to v1: https://lore.kernel.org/r/20261025192302.209354-1-christian.koever-draxl@xxxxxxxxxxxxxxxxxx

Tool use (Documentation/process/generated-content.rst):
This work was done with the help of an AI coding assistant, Claude
(Anthropic), used through Claude Code over many sessions. It did a large
part of the hands-on work: it read the vendor kernel and the firmware
interfaces, probed registers on the board, drafted the code and the
changelogs, and ran the builds, checkpatch, dt_binding_check and the
tests on the hardware. I directed the work, reviewed every change and
the final patches, and take responsibility for them. There is no single
prompt to quote; the sessions were of the form "find out why X fails on
this board, fix it, test it on the box".

Tested on an Amediatech X98Q TV box (Amlogic S905W2, S4 family, 2 GiB),
vendor U-Boot and BL31/OP-TEE, Linux 7.3 plus this work.

.../bindings/media/amlogic,axg-ge2d.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml b/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
index f23fa6d06ad0..f3fe99f1fc95 100644
--- a/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
+++ b/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
@@ -14,6 +14,7 @@ properties:
compatible:
enum:
- amlogic,axg-ge2d
+ - amlogic,s4-ge2d

interrupts:
minItems: 1
@@ -27,6 +28,9 @@ properties:
clocks:
minItems: 1

+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -34,6 +38,19 @@ required:
- clocks
- resets

+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: amlogic,s4-ge2d
+ then:
+ required:
+ - power-domains
+ else:
+ properties:
+ power-domains: false
+
additionalProperties: false

examples:

base-commit: 7be4bc52fd9e0e55dc9a2e0232b89427d2c4b614
--
2.56.0