Re: [PATCH can-next v2 0/9] selftests: can: add J1939 socket and transport tests

[Oleksij Rempel]

On Wed, Nov 04, 2026 at 05:17:15PM +0100, Oleksij Rempel wrote:
> net/can/j1939 has had no in-tree selftests. This series adds a kselftest
> suite for the J1939 socket layer and the TP/ETP transport, run on vcan with
> a CAN_RAW socket as an independent on-the-wire peer.
> 
> The timer checks are relaxed by default, for slow CI machines;
> J1939_STRICT_TIMING selects tight bounds. Not covered yet: the ETP abort
> and timeout paths, and a received Connection Abort on a kernel TX
> session, which the stack currently ignores.
> 
> Known issue: the stack updates a session from the loopback echo of its
> own CTS, RTS and DT frames, and a CAN_RAW peer can see that echo before
> the stack does. A peer frame that follows quickly can then cancel the
> session and fail a multi test. I have not seen this in QEMU runs. The fix
> belongs in the stack, not in these tests.
> 
> I used an LLM coding assistant to write most of the test code and to
> review it. I have read, edited and run all of it myself, on vcan under
> QEMU.
> 
> v1: https://lore.kernel.org/all/20261014154435.3577983-1-o.rempel@xxxxxxxxxxxxxx/

pw-bot: cr

Changes requested by both sashiko instances

Thank you!

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |