Re: [PATCH v4 1/3] dt-bindings: nvmem: add STM32MPX TAMP backup registers
From: Patrice CHOTARD
Date: Fri Nov 06 2026 - 06:16:15 EST
On 11/6/26 12:00, Krzysztof Kozlowski wrote:
> On 06/11/2026 11:33, Patrice CHOTARD wrote:
>>
>>
>> On 11/6/26 11:16, Krzysztof Kozlowski wrote:
>>> On Wed, Nov 04, 2026 at 04:20:08PM +0100, Patrice Chotard wrote:
>>>> + nvmem-layout {
>>>> + compatible = "fixed-layout";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <1>;
>>>> +
>>>> + /* Data cells */
>>>> + wakeup_sec: tamp-bkp@0 {
>>>> + reg = <0x0 0x4>;
>>>> + };
>>>> + boot_mode: tamp-bkp@50 {
>>>> + /*see boot mode selection feature*/
>>>> + reg = <0x50 0x4>;
>>>
>>> Mixed up indentation. Please also run scripts/dtc/dt-check-style and fix
>>> obvious issues.
>>
>> Hi Krzysztof
>>
>> scripts/dtc/dt-check-style doesn't return any errors.
>
> Yes, bindings should adhere to strict mode, see line ~40 in DT
> submitting patches doc. Srtict mode would complain:
>
> Documentation/devicetree/bindings/nvmem/st,stm32-tamp-nvram.yaml:50:
> example 0 [indent-consistent] indent mismatch (expected depth 3 * ' ')
Ok thanks for pointing this.
As the v5 is already available on mailing list, it will trigger the same remark.
it will be fixed in v6, once you will have reviewed the v5.
Patrice
>
>
> Best regards,
> Krzysztof