Re: [PATCH] bus: ti-sysc: Don't reserve the system timers on AM33xx

[Kory Maincent]

On 11/4/26 16:53, Judith Mendez wrote:
> Hi Markus
>
> On 11/3/26 7:24 AM, Markus Schneider-Pargmann (TI) wrote:
> > Commit
> >      3f6178392050 ("ti-sysc: allow OMAP2 and OMAP4 timers to be 
> > reserved on AM33xx")
> > introduced handling of am33 SoC timers that are already active as
> > reserved. During probe this means the clocks are enabled and a reference
> > is kept.
> >
> > On AM33xx deep sleep is entered by the PM coprocessor which
> > requires the PER power domain to be idle. The system timer driver
> > disables the clock during suspend but the additional reference held by
> > ti-sysc leads to the PER power domain not being idle:
> >
> >      pm33xx pm33xx: PM: Could not transition all powerdomains to 
> > target state
> >
> > The reserved status is only needed where the
> > gpt12 system timer must be kept from idling, see commit
> >      3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with 
> > reserved status")
> >
> > The timer configuration in the devicetree is the same on all SoCs, so
> > there is no reason to reserve the timers on AM33xx.
> >
> > Return -ENODEV for the system timers on all other SoCs. Like -EBUSY it
> > stops the probe but the driver core doesn't report it as failure.
> >
> > Fixes: 3f6178392050 ("ti-sysc: allow OMAP2 and OMAP4 timers to be 
> > reserved on AM33xx")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Markus Schneider-Pargmann (TI) <msp@xxxxxxxxxxxx>
>
> Thanks for the patch, tested on various AM3* boards.
>
> Tested-by: Judith Mendez <jm@xxxxxx>

Tested-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
On BeagleBone Green Eco.

Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com