[PATCH net-next 2/5] net: rnpgbe: Report link settings through ethtool
From: Dong Yibo
Date: Fri Nov 06 2026 - 06:29:58 EST
Add get_link_ksettings support to report supported and advertised
link modes, autonegotiation, port type and PHY address. Report copper,
fibre and backplane link modes from firmware, with autonegotiation
support on copper ports.
These devices support autonegotiation only on TP ports. Configure TP
ports with autonegotiation enabled and fibre and backplane ports with
fixed 1 Gb/s full duplex.
Signed-off-by: Dong Yibo <dong100@xxxxxxxxx>
---
drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 13 ++
.../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 28 +++-
.../ethernet/mucse/rnpgbe/rnpgbe_ethtool.c | 126 ++++++++++++++++++
.../net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 7 +
.../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 29 ++++
.../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h | 26 ++++
6 files changed, 227 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
index 2fe76c95da7c..83267d475257 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
@@ -39,11 +39,21 @@ enum {
mucse_fw_link_report_en,
};
+struct mucse_link_config {
+ u32 supported;
+ u32 advertising;
+ u32 speed;
+ u16 status;
+ u8 phy_addr;
+ u8 duplex;
+};
+
struct mucse_hw {
void __iomem *hw_addr;
void __iomem *ring_msix_base;
struct pci_dev *pdev;
struct mucse_mbx_info mbx;
+ struct mucse_link_config link_config;
int port;
int speed;
u32 fw_version;
@@ -51,6 +61,8 @@ struct mucse_hw {
u16 cycles_per_us;
u8 pfvfnum;
u8 duplex;
+ u8 mdix_ctrl;
+ u8 mdix;
};
struct rnpgbe_tx_desc {
@@ -249,6 +261,7 @@ struct mucse {
int rnpgbe_get_permanent_mac(struct mucse_hw *hw, u8 *perm_addr);
int rnpgbe_reset_hw(struct mucse_hw *hw);
int rnpgbe_setup_default_link(struct mucse_hw *hw);
+int rnpgbe_init_link_config(struct mucse_hw *hw);
int rnpgbe_send_notify(struct mucse_hw *hw,
bool enable,
int mode);
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
index dcc8233e024e..a6ab94bd1578 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
@@ -68,8 +68,32 @@ int rnpgbe_reset_hw(struct mucse_hw *hw)
**/
int rnpgbe_setup_default_link(struct mucse_hw *hw)
{
- return mucse_mbx_set_link(hw, RNPGBE_DEFAULT_ADV, true, 0, 0,
- ETH_TP_MDI_AUTO);
+ u32 advertising = hw->link_config.supported & RNPGBE_DEFAULT_ADV;
+ bool autoneg = hw->link_config.status & MUCSE_LINK_TP;
+ u8 duplex = DUPLEX_UNKNOWN;
+ u32 speed = SPEED_UNKNOWN;
+ int err;
+
+ if (!autoneg) {
+ advertising &= RNPGBE_FW_ADV_1000_FULL;
+ speed = SPEED_1000;
+ duplex = DUPLEX_FULL;
+ }
+
+ err = mucse_mbx_set_link(hw, advertising, autoneg,
+ autoneg ? 0 : speed, autoneg ? 0 : duplex,
+ ETH_TP_MDI_AUTO);
+ if (!err) {
+ hw->link_config.advertising = advertising;
+ hw->link_config.speed = speed;
+ hw->link_config.duplex = duplex;
+ if (autoneg)
+ hw->link_config.status |= MUCSE_LINK_AUTONEG;
+ else
+ hw->link_config.status &= ~MUCSE_LINK_AUTONEG;
+ }
+
+ return err;
}
/**
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_ethtool.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_ethtool.c
index 506233f62698..3ff01a15961e 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_ethtool.c
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_ethtool.c
@@ -2,9 +2,134 @@
/* Copyright(c) 2022 - 2026 Mucse Corporation. */
#include <linux/ethtool.h>
+#include <linux/linkmode.h>
#include <linux/pci.h>
#include "rnpgbe.h"
+#include "rnpgbe_mbx_fw.h"
+
+static const struct {
+ u32 fw_mode;
+ u32 ethtool_mode;
+} rnpgbe_tp_modes[] = {
+ { RNPGBE_FW_ADV_10_HALF, ETHTOOL_LINK_MODE_10baseT_Half_BIT },
+ { RNPGBE_FW_ADV_10_FULL, ETHTOOL_LINK_MODE_10baseT_Full_BIT },
+ { RNPGBE_FW_ADV_100_HALF, ETHTOOL_LINK_MODE_100baseT_Half_BIT },
+ { RNPGBE_FW_ADV_100_FULL, ETHTOOL_LINK_MODE_100baseT_Full_BIT },
+ { RNPGBE_FW_ADV_1000_FULL, ETHTOOL_LINK_MODE_1000baseT_Full_BIT },
+};
+
+static void rnpgbe_link_modes(unsigned long *modes, u32 fw_modes)
+{
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(rnpgbe_tp_modes); i++) {
+ if (fw_modes & rnpgbe_tp_modes[i].fw_mode)
+ linkmode_set_bit(rnpgbe_tp_modes[i].ethtool_mode,
+ modes);
+ }
+}
+
+/**
+ * rnpgbe_init_link_config - Cache firmware link capabilities and configuration
+ * @hw: hardware information structure
+ *
+ * Query before port-up: repeated GET_LANE_STATUS commands can prevent
+ * firmware from completing forced 10 Mb/s link setup. Runtime link state
+ * comes from link events instead.
+ *
+ * Return: 0 on success, negative errno on failure
+ */
+int rnpgbe_init_link_config(struct mucse_hw *hw)
+{
+ struct mucse_link_info info;
+ int err;
+
+ err = mucse_mbx_get_link(hw, &info);
+ if (err)
+ return err;
+
+ hw->link_config.supported = le32_to_cpu(info.supported);
+ hw->link_config.advertising = le32_to_cpu(info.advertising);
+ hw->link_config.status = le16_to_cpu(info.status);
+ hw->link_config.phy_addr = info.phy_addr;
+
+ return 0;
+}
+
+static int rnpgbe_get_link_ksettings(struct net_device *netdev,
+ struct ethtool_link_ksettings *cmd)
+{
+ struct mucse *mucse = netdev_priv(netdev);
+ struct mucse_hw *hw = &mucse->hw;
+ u32 supported, advertising;
+ unsigned long flags;
+ u16 status;
+ int mode;
+
+ status = hw->link_config.status;
+ supported = hw->link_config.supported;
+ advertising = hw->link_config.advertising;
+ ethtool_link_ksettings_zero_link_mode(cmd, supported);
+ ethtool_link_ksettings_zero_link_mode(cmd, advertising);
+ ethtool_link_ksettings_zero_link_mode(cmd, lp_advertising);
+ cmd->base.autoneg = AUTONEG_DISABLE;
+ cmd->base.speed = SPEED_UNKNOWN;
+ cmd->base.duplex = DUPLEX_UNKNOWN;
+ cmd->base.eth_tp_mdix = ETH_TP_MDI_INVALID;
+ spin_lock_irqsave(&mucse->link_lock, flags);
+ if (netif_carrier_ok(netdev) && hw->link) {
+ cmd->base.speed = hw->speed;
+ cmd->base.duplex = hw->duplex ?
+ DUPLEX_FULL : DUPLEX_HALF;
+ if (status & MUCSE_LINK_TP)
+ cmd->base.eth_tp_mdix = hw->mdix;
+ }
+ spin_unlock_irqrestore(&mucse->link_lock, flags);
+
+ if (status & MUCSE_LINK_TP) {
+ rnpgbe_link_modes(cmd->link_modes.supported, supported);
+ rnpgbe_link_modes(cmd->link_modes.advertising, advertising);
+ ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
+ ethtool_link_ksettings_add_link_mode(cmd, supported, Autoneg);
+ if (status & MUCSE_LINK_AUTONEG) {
+ cmd->base.autoneg = AUTONEG_ENABLE;
+ ethtool_link_ksettings_add_link_mode(cmd, advertising,
+ Autoneg);
+ }
+ cmd->base.port = PORT_TP;
+ cmd->base.phy_address = hw->link_config.phy_addr;
+ cmd->base.eth_tp_mdix_ctrl = hw->mdix_ctrl;
+ } else {
+ if (status & MUCSE_LINK_BACKPLANE) {
+ mode = ETHTOOL_LINK_MODE_1000baseKX_Full_BIT;
+ ethtool_link_ksettings_add_link_mode(cmd, supported,
+ Backplane);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising,
+ Backplane);
+ cmd->base.port = PORT_NONE;
+ } else {
+ mode = ETHTOOL_LINK_MODE_1000baseX_Full_BIT;
+ ethtool_link_ksettings_add_link_mode(cmd, supported,
+ FIBRE);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising,
+ FIBRE);
+ cmd->base.port = PORT_FIBRE;
+ }
+ if (supported & RNPGBE_FW_ADV_1000_FULL)
+ linkmode_set_bit(mode, cmd->link_modes.supported);
+ if (advertising & RNPGBE_FW_ADV_1000_FULL)
+ linkmode_set_bit(mode, cmd->link_modes.advertising);
+ }
+
+ if (cmd->base.autoneg == AUTONEG_DISABLE) {
+ cmd->base.speed = hw->link_config.speed;
+ cmd->base.duplex = hw->link_config.duplex;
+ }
+
+ return 0;
+}
static void rnpgbe_get_drvinfo(struct net_device *netdev,
struct ethtool_drvinfo *info)
@@ -22,4 +147,5 @@ static void rnpgbe_get_drvinfo(struct net_device *netdev,
const struct ethtool_ops rnpgbe_ethtool_ops = {
.get_drvinfo = rnpgbe_get_drvinfo,
.get_link = ethtool_op_get_link,
+ .get_link_ksettings = rnpgbe_get_link_ksettings,
};
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
index 46981ef2542a..31871b244882 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
@@ -2,6 +2,7 @@
/* Copyright(c) 2020 - 2025 Mucse Corporation. */
#include <linux/pci.h>
+#include <linux/ethtool.h>
#include <linux/skbuff.h>
#include <net/rtnetlink.h>
#include <linux/etherdevice.h>
@@ -169,6 +170,7 @@ static void rnpgbe_sw_init(struct mucse *mucse)
mucse->tx_ring_item_count = M_DEFAULT_TXD;
mucse->rx_ring_item_count = M_DEFAULT_RXD;
mucse->tx_work_limit = M_DEFAULT_TX_WORK;
+ mucse->hw.mdix_ctrl = ETH_TP_MDI_AUTO;
for (i = 0; i < RNPGBE_MAX_QUEUES; i++) {
u64_stats_init(&mucse->tx_stats[i].syncp);
@@ -258,6 +260,11 @@ static int rnpgbe_add_adapter(struct pci_dev *pdev,
dev_err(&pdev->dev, "Hw reset failed %d\n", err);
goto err_powerdown;
}
+ err = rnpgbe_init_link_config(hw);
+ if (err) {
+ dev_err(&pdev->dev, "Get link capabilities failed %d\n", err);
+ goto err_powerdown;
+ }
err = rnpgbe_setup_default_link(hw);
if (err) {
dev_err(&pdev->dev, "Setup link failed %d\n", err);
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c
index 4a1893792751..469818b83d70 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c
@@ -242,6 +242,33 @@ int mucse_mbx_set_link(struct mucse_hw *hw, u32 advertising, bool autoneg,
return err;
}
+/**
+ * mucse_mbx_get_link - Query firmware link settings and capabilities
+ * @hw: hardware information structure
+ * @info: firmware link information returned on success
+ *
+ * Return: 0 on success, negative errno on failure
+ */
+int mucse_mbx_get_link(struct mucse_hw *hw, struct mucse_link_info *info)
+{
+ union mbx_fw_cmd_req_u req = {
+ .r = {
+ .datalen = cpu_to_le16(MUCSE_MBX_REQ_HDR_LEN +
+ sizeof(req.r.get_link)),
+ .opcode = cpu_to_le16(GET_LANE_STATUS),
+ .get_link.port = cpu_to_le32(hw->port),
+ },
+ };
+ union mbx_fw_cmd_reply_u reply = {};
+ int err;
+
+ err = mucse_fw_send_cmd_wait_resp(hw, &req, &reply);
+ if (!err)
+ *info = reply.r.link_info;
+
+ return err;
+}
+
/**
* mucse_mbx_phyup - Request that firmware bring the PHY up or down
* @hw: pointer to the HW structure
@@ -435,6 +462,8 @@ static void mucse_mbx_fw_req_handler(struct mucse_hw *hw,
hw->speed = le16_to_cpu(req->link_stat.st.speed);
hw->duplex = req->link_stat.st.flags & DUPLEX_BIT;
+ hw->mdix = FIELD_GET(ST_STATUS_MDIX_MASK,
+ le16_to_cpu(req->link_stat.st.status));
rnpgbe_set_link(hw, mucse_link_is_up(hw, req));
/* update regs to notify link info is received */
mucse_update_link_status_reg(hw, req);
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h
index 93ce0e796442..e99f6173e67d 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h
@@ -15,6 +15,7 @@ enum MUCSE_FW_CMD {
GET_MAC_ADDRESS = 0x0602,
RESET_HW = 0x0603,
LINK_CHANGE_EVT = 0x0608,
+ GET_LANE_STATUS = 0x0610,
LINK_REPORT_EN = 0x0613,
PHY_LINK_SET = 0x0630,
SET_PHY_UP = 0x0800,
@@ -27,6 +28,25 @@ enum MUCSE_FW_CMD {
#define RNPGBE_FW_ADV_10_HALF BIT(10)
#define RNPGBE_FW_ADV_100_HALF BIT(11)
+struct mucse_link_info {
+ u8 reserved0[4];
+ __le16 status;
+ u8 phy_addr;
+ u8 reserved1;
+ __le32 speed;
+ __le32 reserved2[4];
+ __le32 supported;
+ __le32 phy_id;
+ __le32 advertising;
+} __packed;
+
+#define MUCSE_LINK_UP BIT(0)
+#define MUCSE_LINK_FULL_DUPLEX BIT(1)
+#define MUCSE_LINK_AUTONEG BIT(2)
+#define MUCSE_LINK_TP BIT(7)
+#define MUCSE_LINK_BACKPLANE BIT(12)
+#define MUCSE_LINK_MDIX GENMASK(14, 13)
+
struct mucse_hw_info {
u8 link_stat;
u8 port_mask;
@@ -47,6 +67,7 @@ struct mucse_hw_info {
} __packed;
#define ST_STATUS_LLDP_STATUS_MASK BIT(12)
+#define ST_STATUS_MDIX_MASK GENMASK(11, 10)
#define DUPLEX_BIT BIT(0)
struct st_status {
@@ -87,6 +108,9 @@ struct mbx_fw_cmd_req {
__le32 nr_lane;
__le32 tp_mdix_ctrl;
} phy_link_set;
+ struct {
+ __le32 port;
+ } get_link;
struct {
/* LINK_REPORT_EN uses its own 16-bit payload layout:
* status precedes port_mask.
@@ -123,6 +147,7 @@ struct mbx_fw_cmd_reply {
} addrs[4];
} mac_addr;
struct mucse_hw_info hw_info;
+ struct mucse_link_info link_info;
};
} __packed;
@@ -156,6 +181,7 @@ int mucse_mbx_get_macaddr(struct mucse_hw *hw, int pfvfnum,
u8 *mac_addr, int port);
int mucse_mbx_set_link(struct mucse_hw *hw, u32 advertising, bool autoneg,
u32 speed, u32 duplex, u32 mdix_ctrl);
+int mucse_mbx_get_link(struct mucse_hw *hw, struct mucse_link_info *info);
int mucse_mbx_phyup(struct mucse_hw *hw, bool is_phyup);
int mucse_mbx_link_report(struct mucse_hw *hw, bool is_report);
void mucse_fw_irq_handler(struct mucse_hw *hw);
--
2.50.1