Re: [PATCH net-next 1/5] net: ethernet: oa_tc6: Allow custom reset settle time values

From: Stolniceanu, Iustin

Date: Fri Nov 06 2026 - 06:38:11 EST


On Wed, Nov 04, 2026 at 03:10:56PM +0100, Alvin Šipraga wrote:
> Would it maybe make sense to split this into two quirk values? Something
> like hwreset_settle_us and softreset_settle_us? The ADIN1110 datasheet
> seems to have a slightly lower value for software reset.

Yes. The datasheet gives 50 ms max after RESET is deasserted and
10 ms max after a software reset. v2 will have two fields,
hwreset_settle_us (default 1000 when not set, as today) and
softreset_settle_us (default 0), and the ADIN1110 will set 50000 and
10000.

> If you have a separate softreset version, you can just set the value
> if (quirks) and flseep() here unconditionally.

Will do. Since the default is 0, I'll apply the hwreset default in
oa_tc6_init() as well, so both call sites become a plain fsleep().

Thanks,
Iustin