Re: [PATCH v2 bpf-next 3/3] selftests/bpf: Add a runtime test for private stack and stack arguments

[Chen Pei]

Hi Alexei,

Thanks for the review and for writing out the two programs.

> bpf ci is right in the other email.

Okay, will fix it in the next version.

> Also, the test runs on riscv64 only. BPF CI runs arm64 and not riscv64.
> arm64 has the same combination and no test for it.
> The run time part has nothing specific to riscv64.
> The __jited patterns pin the frame sizes that clang picks for C code.
> zero_stack doesn't use the private stack.
> It's the only reason for serial_.
>
> Two asm progs in verifier_stack_arg.c are enough.
> BPF_PROG_TEST_RUN runs a raw_tp prog. No need to attach it.
> The test runs on x86-64, arm64 and riscv64.
> On x86-64 both frames stay on the kernel stack.

Agreed, will redo the test this way in the next version.

Best regards,
Chen