Re: [PATCH] net: prestera: release the ruleset in prestera_flower_prio_get

From: Simon Horman

Date: Fri Nov 06 2026 - 07:17:48 EST


On Tue, Nov 03, 2026 at 10:05:32AM +0000, Wentao Liang wrote:
> prestera_flower_prio_get() looks up the ruleset with
> prestera_acl_ruleset_lookup(), which increments its reference count,
> but returns without calling prestera_acl_ruleset_put().
>
> The ruleset reference is leaked on every successful priority query.
> Release it after the priority range has been copied out.
>
> Fixes: 44af95718fed ("net: prestera: manage matchall and flower priorities")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

Hi Wentao,

While I have reservations about the large number of patches you
have sent to netdev in the past days, as others have commented,
I do believe this patch is correct.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>