Re: [PATCH net v3] xsk: Do not free ZC Rx buffer when the Rx ring is full

From: Marcin Knap

Date: Fri Nov 06 2026 - 07:40:36 EST



> - [Medium] After this patch, ixgbe's need_wakeup -ENOBUFS path keeps a
> live buffer and runs XDP on it again, but with stale data pointers.

This is pre-existing. ixgbe already ran XDP again on the same buffer
before this patch, and data and data_meta were not reset then either.
The only difference was that the buffer had already been freed by
xsk_rcv_zc() and could be on the pool free list. The stale pointers are
not introduced here. As discussed for v2, ixgbe is left for a follow-up.

The review also points out that igb never returns IGB_XDP_EXIT
(out_failure falls through to XDP_DROP, which sets IGB_XDP_CONSUMED),
so v4 removes igb from that part of the commit message.

> Pre-existing issues:
> - [High] The rule that the caller owns the buffer when redirect fails
> still breaks when a zero-copy buffer is redirected to anything other…

Agreed, this is pre-existing. xdp_convert_zc_to_xdp_frame() frees the
ZC buffer before a non-XSKMAP redirect can still fail. It is separate
from the XSKMAP -ENOBUFS path fixed here; v4 says in the commit message
that the fix covers XSKMAP redirects.

> - [High] In otx2_xdp_rcv_pkt_handler()
> (drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c), the two…
> - [High] In otx2_xdp_rcv_pkt_handler()
> (drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c), the AF_XDP…

Both are pre-existing otx2 issues that are not related to the ZC Rx
ring full path, so they are not addressed by this patch.

pw-bot: cr