RE: [PATCH 2/3] drm/panthor: Add initial support for CIX Sky1

[Cunyuan Liu (刘存原)]

Hi Philipp,

On Fri, Nov 06, 2026, Philipp Zabel wrote:
> You can just use devm_reset_control_get_optional_exclusive()
> unconditionally. Device tree validation makes sure the required reset
> will be specified.

Thanks for the review. I have switched to
devm_reset_control_get_optional_exclusive() unconditionally.

> reset_control_reset() already checks that ptdev->reset_control != NULL,
> so the first check is superfluous.

I have removed the NULL check and kept the
!panthor_device_is_initialized() condition.

> +       bool needs_external_reset;
>
> Not needed.

I have removed this field from the Sky1 SoC data.

I have tested these changes locally and they work. I plan to include
these changes in v2 after waiting for any other review comments.

Best regards,
Cunyuan