Re: [PATCH 0/2] ASoC: amd: acp: supplement patches for ACP7.B/7.F SoundWire machine driver series
From: Pierre-Louis Bossart
Date: Fri Nov 06 2026 - 08:12:11 EST
On 11/6/26 14:07, Vijendar Mukunda wrote:
> These two patches address nit-picks raised in review of the ACP7.B/7.F
> SoundWire machine driver series posted at:
>
> https://lore.kernel.org/all/20261030094714.1123396-1-Vijendar.Mukunda@xxxxxxx/
>
> These patches were previously posted as replies to the original
> series. Posting them now as a standalone series to keep the dependency
> clear and avoid threading new patches under the existing review.
>
> Patch 1 renames three static adr_device arrays in amd-acp7x-acpi-match.c
> to reflect their endpoint set rather than their structural role, making the
> distinction between jack+dmic (combo with RT1320) and jack+amp+dmic
> (standalone) self-explanatory.
>
> Patch 2 adds a block comment above the ASOC_SDW_ACP_DMIC and
> ASOC_SDW_ACP_DMIC1 quirk bit definitions to document the dual-PDM-
> controller hardware model of ACP7.B/7.F, and annotates each bit with its
> role. ASOC_SDW_ACP_DMIC is a generic DMIC-enable flag on all ACP
> platforms; on ACP7.B/7.F it additionally identifies the PDM0 controller.
> ASOC_SDW_ACP_DMIC1 is ACP7.B/7.F-specific for PDM1. BIOS wires exactly
> one controller per platform.
>
> Vijendar Mukunda (2):
> ASoC: amd: acp: fix adr_device naming in ACP7.x ACPI match table
> ASoC: amd: acp: document PDM controller topology for ACP7.B/7.F
>
> sound/soc/amd/acp/amd-acp7x-acpi-match.c | 22 +++++++++++-----------
> sound/soc/amd/acp/soc_amd_sdw_common.h | 11 +++++++++--
> 2 files changed, 20 insertions(+), 13 deletions(-)
thanks for the patches
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>