Re: [PATCH v6 03/10] drm/panel: Convert LG LH400WV3-SD04 to use MIPI DBI bus

[Thierry Reding]

On Thu, Nov 05, 2026 at 04:05:03PM +0200, Svyatoslav Ryhel wrote:
> Switch from a generic platform driver to a dedicated MIPI DBI driver.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-lg-lh400wv3.c | 103 ++++++++++------------
>  1 file changed, 46 insertions(+), 57 deletions(-)

Same comments as for the previous patch.

> diff --git a/drivers/gpu/drm/panel/panel-lg-lh400wv3.c b/drivers/gpu/drm/panel/panel-lg-lh400wv3.c
[...]
> -#define panel_dbi_command(priv, cmd, seq...) \
> +#define panel_dbi_command(dbidev, cmd, seq...) \

This probably also applied to the previous patch, but there seems to be
no reason for this change and the related changes below.

>  ({ \
>  	const u8 d[] = { seq }; \
> -	struct drm_panel *panel = &(priv)->panel; \
> -	struct device *dev = panel->dev; \
> +	struct device *dev = &(dbidev)->dev; \
>  	int ret; \
> -	ret = mipi_dbi_command_stackbuf((priv)->dbi, cmd, d, ARRAY_SIZE(d)); \
> +	ret = mipi_dbi_command_stackbuf((dbidev)->dbi, cmd, d, ARRAY_SIZE(d)); \
>  	if (ret) \
>  		dev_err_ratelimited(dev, "error %d when sending command %#02x\n", ret, cmd); \
>  	ret; \
[...]
> @@ -177,14 +166,13 @@ static int lg_lh400wv3_get_modes(struct drm_panel *panel,
>  static const struct drm_panel_funcs lg_lh400wv3_panel_funcs = {
>  	.prepare = lg_lh400wv3_prepare,
>  	.enable = lg_lh400wv3_enable,
> -	.disable = lg_lh400wv3_disable,
>  	.unprepare = lg_lh400wv3_unprepare,
>  	.get_modes = lg_lh400wv3_get_modes,
>  };

It's not obvious, and also not documented, why .disable is removed.

Thierry

Attachment: signature.asc
Description: PGP signature