Re: [PATCH v2 3/3] KVM: arm64: Don't replace a valid hyp block mapping with a table
From: Fuad Tabba
Date: Fri Nov 06 2026 - 09:41:11 EST
On Fri, 6 Nov 2026 at 14:34, Xuheng Li <xuheng@xxxxxxxxxxxxxxx> wrote:
>
> Hi Fuad,
>
> On Fri, Nov 06, 2026 at 12:03:29PM +0000, Fuad Tabba wrote:
> > Could you mention in the message that the WARN_ON() is fatal at EL2,
> > so a caller there gets a hyp panic rather than -EEXIST?
> > kvm_pgtable_hyp_map() is already documented as rejecting such a
> > mapping "with an error and a WARN()", which is a better reason than a
> > future caller.
>
> Thanks. I'll reword the message to say that the WARN_ON() is fatal at
> EL2, and point to kvm_pgtable_hyp_map()'s documented "error and a
> WARN()" instead of a future caller. With patches 1 and 2 dropped, I'll
> resend this one on its own once reviews have settled.
Actually, like Vincent pointed out, why the WARN_ON(). The caller can
just handle the error.
Cheers,
/fuad