Re: [PATCH net 1/2] net: dsa: realtek: rtl8365mb: use IVL in VLAN 0

[Stijn Cleynhens]

On Wed, Nov 04, 2026 at 04:22:58PM +0100, Alvin Šipraga wrote:
> Yes, all this makes sense. I actually remember doing basically the same
> thing back when I was working on this, but it seems not to have survived
> the final work by Luiz. It would be good to get his input on why.

Luiz, do you remember a reason the IVL setup of VID 0 was dropped? I
could not find one, and the switch only matches the driver's VID 0
entries with it.

> So I'm not sure I like this function being added to the vlan.c
> library. Semantically it makes more sense to me for the main.c driver to
> actually call rtl8365mb_vlan4k_port_add() for each port, so as to
> explicitly say: "all ports are, one way or another, members of this
> neutral VLAN". Then you would get IVL automatically.

I kept it out of rtl8365mb_vlan_4k_port_add() on purpose: making every
port a member of VID 0 also sets the member mask, which the ingress
filter of a VLAN-aware port then checks. I only wanted to change the
learning mode, not which frames a filtering port accepts.

> Reviewed-by: Alvin Šipraga <alvin.sipraga@xxxxxxxxxx>

Thanks!

Stijn