[PATCH 5/5] pwm: rockchip: Fix pclk leak in get_state error path

From: shao.mingyin

Date: Fri Nov 06 2026 - 11:14:08 EST


From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>

rockchip_pwm_get_state() enables pc->pclk and then pc->clk. If
clk_enable(pc->clk) fails the function returns immediately, leaving
pc->pclk enabled. The clock therefore stays on after a failed readback,
and its enable count grows with every retry; unbinding the driver then
hits "Unpreparing enabled" in the clock core.

Disable pc->pclk on the error path.

Fixes: 11be938ae003 ("pwm: rockchip: Enable clock before calling clk_get_rate()")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
---

diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 050ca8aad0ca..17cf1e28a3c8 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -76,7 +76,7 @@ static int rockchip_pwm_get_state(struct pwm_chip *chip,

ret = clk_enable(pc->clk);
if (ret)
- return ret;
+ goto err_clk;

clk_rate = clk_get_rate(pc->clk);

@@ -100,6 +100,10 @@ static int rockchip_pwm_get_state(struct pwm_chip *chip,
clk_disable(pc->pclk);

return 0;
+
+err_clk:
+ clk_disable(pc->pclk);
+ return ret;
}

static void rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
--
2.47.0