Re: [PATCH v2 1/2] usb: typec: ucsi: acpi: Rename the Acer zero version quirk

[Heikki Krogerus]

On Tue, Nov 03, 2026 at 05:10:20PM +0100, Stanisław Titenko via B4 Relay wrote:
> From: Stanisław Titenko <kernel@xxxxxxxxxx>
> 
> The quirk added for the Acer Nitro ANV15-41 is not specific to that
> machine: it substitutes UCSI 1.2 when the firmware reports a zero
> version, which other platforms with the same firmware bug need too.
> 
> Rename ucsi_acer_read_version() and ucsi_acer_ops to
> ucsi_zero_version_read_version() and ucsi_zero_version_ops, so that
> they can be shared with other machines.
> 
> No functional change.
> 
> Cc: stable@xxxxxxxxxxxxxxx # needed by the next patch
> Assisted-by: pi:claude-opus-5-5
> Signed-off-by: Stanisław Titenko <kernel@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/ucsi_acpi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
> index 5697ccc24ec3..47ba0e15b8ba 100644
> --- a/drivers/usb/typec/ucsi/ucsi_acpi.c
> +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
> @@ -121,7 +121,7 @@ static const struct ucsi_operations ucsi_acpi_ops = {
>  	.async_control = ucsi_acpi_async_control
>  };
>  
> -static int ucsi_acer_read_version(struct ucsi *ucsi, u16 *version)
> +static int ucsi_zero_version_read_version(struct ucsi *ucsi, u16 *version)
>  {
>  	struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
>  	int ret;
> @@ -138,8 +138,8 @@ static int ucsi_acer_read_version(struct ucsi *ucsi, u16 *version)
>  	return 0;
>  }
>  
> -static const struct ucsi_operations ucsi_acer_ops = {
> -	.read_version = ucsi_acer_read_version,
> +static const struct ucsi_operations ucsi_zero_version_ops = {
> +	.read_version = ucsi_zero_version_read_version,
>  	.read_cci = ucsi_acpi_read_cci,
>  	.poll_cci = ucsi_acpi_poll_cci,
>  	.read_message_in = ucsi_acpi_read_message_in,
> @@ -194,7 +194,7 @@ static const struct dmi_system_id ucsi_acpi_quirks[] = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Nitro ANV15-41"),
>  		},
> -		.driver_data = (void *)&ucsi_acer_ops,
> +		.driver_data = (void *)&ucsi_zero_version_ops,
>  	},
>  	{
>  		.matches = {
> 
> -- 
> 2.56.0
> 

-- 
heikki