Re: [PATCH 3/3] spmi: Add SmartDV SPMI controller driver

[Uwe Kleine-König]

Hello,

On Tue, Nov 03, 2026 at 09:56:07AM +0530, vamshi gajjela wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>

Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
good enough to provide of_device_id already. If you insist on full iwyu,
please use <linux/device-id/of.h> instead.

> [...]
> +static const struct of_device_id smartdv_spmi_of_match[] = {
> +	{ .compatible = "smartdv,spmi" },
> +	{}

{ } please

> +};
> +MODULE_DEVICE_TABLE(of, smartdv_spmi_of_match);

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature