Re: [PATCH v2] dmaengine: qcom_hidma: Fix runtime PM leak in hidma_issue_task()

[Frank Li]

On Fri, Nov 06, 2026 at 08:42:52AM -0000, Wentao Liang wrote:
> hidma_issue_task() bumps the device usage counter with
> pm_runtime_get_sync() without checking the return value. The counter is
> incremented even when the resume fails, e.g. when runtime PM has been
> disabled or the device is suspending, and nothing drops it in that case,
> so each failure leaves the device with an elevated usage count and it can
> no longer runtime suspend.
>
> Use pm_runtime_resume_and_get(), which drops the reference it took when
> the resume fails, and do not start the transfer in that case. The counter
> taken by a successful resume is still dropped by hidma_callback() as
> before.
>
> Fixes: 67a2003e0607 ("dmaengine: add Qualcomm Technologies HIDMA channel driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---

Krzysztof already report at many threads

https://lore.kernel.org/all/e34e5630-2f3e-4f7f-9f47-4fec11c1a61e@xxxxxxxxxx/
https://lore.kernel.org/imx/20261104-small-pompous-basilisk-ac9df8@quoll/

vulab@xxxxxxxxxxx is bot, which is not real person.

If you can't reply and clear this situation, I will mark all patches from
vulab@xxxxxxxxxxx as not appliable at patchworks for dmaengine.

Frank