Re: [PATCH rtw-next v2 5/7] wifi: rtw88: 88xxa: correct carrier-frequency offset

[Luka Gejak]

Hi Jie Feng,

A few small comments below.

October 31, 2026 at 8:09 AM, "Ho Jie Feng" <hjf3108@xxxxxxxxx> wrote:

> diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
> index d0c1fb65be9563c5fc29a7d18a1c9e8589730b10..69998c0d7c1f851bb30d2702233d62e14b305bf0 100644
> --- a/drivers/net/wireless/realtek/rtw88/phy.c
> +++ b/drivers/net/wireless/realtek/rtw88/phy.c
> @@ -687,13 +687,14 @@ static void rtw_phy_parsing_cfo_iter(void *data, u8 *mac,
>       struct rtw_rx_pkt_stat *pkt_stat = iter_data->pkt_stat;
>       struct rtw_dm_info *dm_info = &rtwdev->dm_info;
>       struct rtw_cfo_track *cfo = &dm_info->cfo_track;
> +     u8 path_num = min_t(u8, rtwdev->hal.rf_path_num, 2);

This and the same line in rtw_phy_cfo_xcap_track() are in core code that
every chip uses. As far as I can see the limit is only there for 8814a,
which has four paths but reports a CFO tail only for A and B. A short
comment saying so would help, otherwise the 2 looks arbitrary.

The commit message could mention this core change too, together with
the CFO tracking for 8814a that this patch adds.

[ ... ]

> diff --git a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> index 87253fffe78cd6f5b58a325eef42b58b968e2d46..851d198f76f3b10d5ba77c7e07e4be9d7fd54e4b 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> @@ -279,6 +279,7 @@ int rtw88xxa_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
>       efuse->crystal_cap = map->xtal_k;
>       if (efuse->crystal_cap == 0xff)
>               efuse->crystal_cap = 0x20;
> +     efuse->crystal_cap &= 0x3F;

[ ... ]

> +     rtw88xxa_set_crystal_cap(rtwdev, rtwdev->efuse.crystal_cap & 0x3F);

With the mask in rtw88xxa_read_efuse() the & 0x3F here isn't needed
anymore.

The 6 bit limit now shows up as 0x3F or 0x3f in five places across
rtw88xxa.c and rtw8814a.c. Maybe a define in rtw88xxa.h, which
rtw8814a.c includes too, similar to XCAP_MASK in rtw8822c.h.

Best regards,
Luka Gejak