Re: [PATCH rtw-next v2 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions

[Luka Gejak]

Hi Jie Feng,

One comment below.

October 31, 2026 at 8:09 AM, "Ho Jie Feng" <hjf3108@xxxxxxxxx> wrote:

> diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> index 0f23498b5c96e406581c06a524e9f270873866ae..f7d7b66844862ff01533b8b640ed35738169673d 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -1585,7 +1585,7 @@ static void rtw_init_ht_cap(struct rtw_dev *rtwdev,
>
>       if (rtw_chip_has_rx_ldpc(rtwdev))
>               ht_cap->cap |= IEEE80211_HT_CAP_LDPC_CODING;
> -     if (rtw_chip_has_tx_stbc(rtwdev))
> +     if (rtw_chip_has_tx_stbc(rtwdev) && rtwdev->hal.rf_path_num > 1)
>               ht_cap->cap |= IEEE80211_HT_CAP_TX_STBC;

This also changes 8822c, which already had tx_stbc set. When its hw
feature report says one antenna, rtw_hw_config_rf_ant_num() sets
rf_path_num to 1 and it stops advertising HT TX STBC. That looks right
to me, the VHT side already checks rf_path_num the same way, but it
would be good to mention it in the commit message.

Best regards,
Luka Gejak