Re: [PATCH 3/6] dmaengine: plx_dma: use writel() for the 32-bit PLX_REG_CTRL register

[Frank Li]

On Tue, Nov 03, 2026 at 09:51:58AM -0600, Logan Gunthorpe wrote:
> plx_dma_issue_pending() writes PLX_REG_CTRL with writew(), but it is a
> 32-bit register and every other access uses writel()/readl().
>
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Link: https://lore.kernel.org/dmaengine/20260717223217.B6FBF1F000E9@xxxxxxxxxxxxxxx
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/dma/plx_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index bfccbb0c70e8..1c995f0c4463 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -351,7 +351,7 @@ static void plx_dma_issue_pending(struct dma_chan *chan)
>  	 */
>  	wmb();
>
> -	writew(PLX_REG_CTRL_START_VAL, plxdev->bar + PLX_REG_CTRL);
> +	writel(PLX_REG_CTRL_START_VAL, plxdev->bar + PLX_REG_CTRL);
>
>  	rcu_read_unlock();
>  }
> --
> 2.47.3
>