Re: [PATCH v1 1/2] dt-bindings: pinctrl: qcom,tlmm-common: Add wakeup-enable
From: Alexander Koskovich
Date: Fri Nov 06 2026 - 13:27:59 EST
On Tuesday, October 20th, 2026 at 2:19 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On Thu, Oct 15, 2026 at 07:52:59PM +0530, Mohammad Rafi Shaik wrote:
> > The TLMM can gate whether a toggle of a pad is transferred to the wake up
> > controller (PDC/MPM) while the system is in a low power mode. The pinctrl
> > driver arms this for pins it requests as GPIO interrupts, but that path
> > takes over the pin mux, so it cannot be used for a pin that has to stay
> > muxed to a peripheral function.
> >
> > Such a pin exists on boards with a SoundWire codec: while the bus is clock
> > stopped the codec requests a wake up by toggling the SoundWire data line,
> > which is muxed to the SoundWire function and not to GPIO. Unless the pad is
> > armed, the toggle never reaches the wake up controller, the controller is
> > never resumed and the event - a headset insertion, for instance - is lost
> > until something else happens to wake the bus.
> >
> > Add a pin configuration property so such a pin can be armed from its own
> > pin configuration, without being turned into a GPIO.
> >
> > Assisted-by: Claude Opus 5
> > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> > index aec72e8c0..95f539611 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> > @@ -87,6 +87,18 @@ $defs:
> > output-high: true
> > output-low: true
> >
> > + wakeup-enable:
>
> As Sashiko points, there is no such generic property.
>
> Anyway, the wekeup is per device rather. Arming a pin would be different
> sleep function, no?
Heads up this also appears to be needed outside of sleep, was looking at NFC
enablement on the Nothing Phone (3a) and left out clock from DT since MGPI
is meant to handle CLK_REQ and enable relevant clock, but MGPI does not
work unless the wakeup_enable bit is set on the pin.
>
> Best regards,
> Krzysztof
>
>
>