Re: [PATCH v3 3/5] drm/ingenic: Add a driver for the X1600 display controller

[Olivier Louvignes]

Hi Paul,

On Fri, Nov 06, 2026 at 04:06:50PM +0100, Paul Cercueil wrote:
> Is there really a point in enabling the clock on-demand? Why not keep it enabled
> always? It makes the driver more complex and I don't see a real benefit.

Fair enough. I have nothing on the R1 to measure what the gate saves,
and the PLL it divides from keeps running for the MMC controllers
anyway. v4 enables the clock in probe and keeps it on until unbind, as
ingenic-drm-drv.c does, and moves the timing block to
atomic_mode_set() as you suggested first.

Thanks,
Olivier