Re: [PATCH 2/2] iio: magnetometer: add Infineon TLE493D-W2B6 driver

[Victor Chernyakin]

> Based on the TLE493D-W2B6 User Manual v1.11 and Datasheet v1.2.
> 
> Datasheet: https://www.infineon.com/assets/row/public/documents/30/49/infineon-tle493d-w2b6-datasheet-en.pdf
> Signed-off-by: Viral Patel <viral8854@xxxxxxxxx>

You should link to the user manual too, since that's where most of
the information relevant to programming the driver is.
I see that it's not available from the Infineon website without a login,
but it's easy to find elsewhere:

https://assets.sourcengine.com/datasheets/c9ebe749-34ab-4924-ab2b-aa7d4dd15e25.pdf

> +/* I2C addresses selected by IICadr, i.e. the default of variants A0 to A3 */
> +static const u8 tle493d_i2c_addrs[] = { 0x35, 0x22, 0x78, 0x44 };
> +

The manual seems to list these addresses as 0x6A, 0x44, 0xF0, 0x88 (Table 4,
p. 14). Can you explain how you go from those values to the ones in
the code?