Re: [PATCH v7 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver

[Markus Elfring]

…
> +++ b/drivers/i2c/busses/i2c-amlogic-a9.c
> @@ -0,0 +1,432 @@
…
> +static irqreturn_t aml_i2c_irq(int irqno, void *dev_id)
> +{
…
> +	spin_lock(&i2c->lock);
> +
> +	irq_state = readl(i2c->regs + REG_CFG_IRQ_STATE);
> +	if (i2c->state == A9_STATE_IDLE) {
> +		dev_warn(i2c->dev, "i2c irq triggered abnormally, irq_state:0x%x,irq_en:0x%x\n",
> +			 irq_state, readl(i2c->regs + REG_CFG_IRQ_ENABLE));
> +		clear_irq_status(i2c, IRQ_ALL_MASK);
> +		spin_unlock(&i2c->lock);
> +		return IRQ_HANDLED;
> +	}
…

Please avoid duplicate source code a bit more for such a function implementation.

Regards,
Markus