Re: [PATCH] clocksource: Use the clocksource under test for the skew check timeout

From: Thomas Gleixner

Date: Fri Nov 06 2026 - 15:35:49 EST


On Thu, Nov 05 2026 at 15:22, Mani Tofigh wrote:
> On 11/3/26 3:20 PM, Thomas Gleixner wrote:
>> So your reproducer does:
>>
>> while true; do echo 0 >/sys/devices/system/cpu/cpu1/online; echo 1 >/sys/devices/system/cpu/cpu1/online; done
>>
>> right?
>>
> Yes, but on a kernel booted with clocksource=jiffies.

I did so too and it did not happen within a couple of hours :(

>> Can you and Srikanth please run that on top to validate that we don't
>> end up with that?
> I ran my patch with your delta in the same guest and it holds up well.
> No hang and no "stalled" warning (even though the remote read timed out
> a lot during the loop).
>
> Do you want the delta in v2? I can carry it as a separate patch from you
> or fold it into mine, whatever you prefer.

Just fold it in. It makes sense in that context.

Thanks,

tglx