Re: [PATCH net-next v2 0/2] devlink: do not dereference a missing param item or shared buffer

From: Jakub Kicinski

Date: Fri Nov 06 2026 - 15:59:25 EST


On Mon, 2 Nov 2026 21:15:03 +0800 Linkui Xiao wrote:
> Two devlink helpers look an object up by id or index, warn when the
> lookup fails, and then pass the NULL result to code that dereferences
> it. A driver mistake (a param_id that was never registered, an sb_index
> that was never registered or is unregistered twice) therefore costs an
> oops instead of a warning.

This is a very low value contribution.

Please think harder whether the changes you're making are worth
community's time.