RE: [PATCH iwl-net 10/10] ice: fix unsigned stat widths
From: Nowlin, Alexander
Date: Fri Nov 06 2026 - 23:59:03 EST
> -----Original Message-----
> From: Petr Oros <poros@xxxxxxxxxx>
> Sent: Friday, October 2, 2026 6:08 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Oros, Petr <poros@xxxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>; Stanislav Fomichev <sdf@xxxxxxxxxxx>; Henry Tieman > <henry.w.tieman@xxxxxxxxx>; Anirudh Venkataramanan <anirudh.venkataramanan@xxxxxxxxx>; Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>; Jesse Brandeburg <jbrandeb@xxxxxxxxxx>; Preethi Banala <preethi.banala@xxxxxxxxx>; Kiran Patil <kiran.patil@xxxxxxxxx>; Dan Nowlin <dan.nowlin@xxxxxxxxx>; Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx
> Subject: [PATCH iwl-net 10/10] ice: fix unsigned stat widths
>
> tx_restart, tx_busy, rx_buf_failed and rx_page_failed in struct ice_vsi are u32, but ice_update_vsi_ring_stats() fills them with sums of the 64-bit per ring counters. The values are truncated and the ethtool statistics exported from them wrap at 2^32 while the ring counters keep counting.
>
> Make them u64 like tx_linearize next to them.
>
> i40e fixed the same truncation in commit 3b8428b84539 ("i40e: fix unsigned stat widths").
>
> Fixes: fcea6f3da546 ("ice: Add stats and ethtool support")
> Assisted-by: LLM
> Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>