Re: [PATCH v2 2/2] wifi: rtw88: ps: Trigger firmware recovery when failing to leave LPS state

[Kalpesh Solanki]

Hi Luka,

Thanks for the clarification and the tip regarding --in-reply-to!

> That is fine for the flag, but I think the counter should be reset in
> rtw_core_start(), like rtw89 does. A normal recovery never calls
> rtw_ops_stop(), so the counter would stay at the limit and the next
> single timeout would recover again.

Good point. Putting rtwdev->ps_hang_cnt = 0 in rtw_core_start() ensures it gets
cleared after both normal starts and hw restarts. I'll place it there.

> The RESTARTING gap predates your patch, since 5c831644e1f4 ("rtw88:
> handle and recover when firmware crash"), so that one could go on its
> own with a Fixes: tag.

Makes sense. I'll send that as a standalone fix with the Fixes: tag.

> For the counter, maybe it is cleaner to revert 2/2 (or rebase and drop
> it since it is currently the HEAD commit of rtw-next) and send a new
> patch, since it replaces that line anyway and keeps the current
> behavior out of the next pull. 1/2 is fine as it is. Ping-Ke, would
> that work for you, or do you prefer a follow up?

Either way works for me. If Ping-Ke prefers to drop 2/2 from rtw-next, I can
send the updated patch with the consecutive counter directly. Otherwise I can
send it as a follow-up on top.

Thanks,
Kalpesh