Re: [PATCH v1 07/10] kconfig-checker: Introduce overlays schema
From: sashiko-bot
Date: Sat Nov 07 2026 - 04:21:26 EST
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] kconfig-checker: overlay.yml example uses invalid expected value
allow
--
commit a10c99db2994945ab80143ea62fe4f2801513046
Author: Ahmed S. Darwish <darwi@xxxxxxxxxxxxx>
kconfig-checker: Introduce overlays schema
This commit introduces a JSON schema for kconfig-checker overlay files
that references base.yml without requiring expected and severity on every
rule.
> diff --git a/tools/kconfig-checker/schemas/overlay.yml b/tools/kconfig-checker/schemas/overlay.yml
> new file mode 100644
> index 0000000000000..4ac9a364a3441
> --- /dev/null
> +++ b/tools/kconfig-checker/schemas/overlay.yml
> @@ -0,0 +1,28 @@
[ ... ]
> +# and a custom-overlay.yml:
> +#
> +# rules:
> +# - name: CONFIG_DRM
> +# expected: allow
[Severity: Low]
Should this example use "expected: allowed" instead of "expected: allow"?
base.yml restricts expected to y, n, or allowed, so an overlay written
from this example fails schema validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106091922.7560-1-darwi@xxxxxxxxxxxxx?part=7