Re: [PATCH] fpga: altera-hps2fpga: do not request reset by index

[Xu Yilun]

On Fri, Nov 06, 2026 at 04:43:19PM +0100, Philipp Zabel wrote:
> There is no need to request a single reset by index.
> Use of_reset_control_get_exclusive() to request the first and only
> reset.
> 
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  drivers/fpga/altera-hps2fpga.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index f2f1250689cb..9b7f5b8191b8 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -134,8 +134,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>  
>  	priv = (struct altera_hps2fpga_data *)device_get_match_data(dev);
>  
> -	priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> -								     0);
> +	priv->bridge_reset = of_reset_control_get_exclusive(dev->of_node, NULL);

Saved a 0 arg but add a NULL arg, Any benifit to justify the code churn?

>  	if (IS_ERR(priv->bridge_reset)) {
>  		dev_err(dev, "Could not get %s reset control\n", priv->name);
>  		return PTR_ERR(priv->bridge_reset);
> 
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261106-reset-deindex-fpga-f203618612b1
> 
> Best regards,
> --  
> Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> 
>