Re: [PATCH v2] ALSA: control: Synchronize LED mode accesses

From: Takashi Iwai

Date: Sat Nov 07 2026 - 08:59:56 EST


On Sat, 07 Nov 2026 13:12:35 +0100,
Sreeraj S Kurup wrote:
>
> Hi Takashi,
>
> I would like to kindly follow up on my first patch.
>
> Could you please let me know if you have had a chance to review it?
>
> For reference, here is the patch link:
> https://lore.kernel.org/all/20261106162357.3616-1-sreekuttan2156239@xxxxxxxxx/

I'm still considering what's the best way.

Your patch replaces and adds some open-code, which isn't nice.
OTOH, it's a small change, so it's acceptable.

An alternative would be to use simple_strtoul() that can return the
end pointer. Or, we may reorganize the whole code a bit, so that to
get the delimiter at first (instead of the head of the next word),
then clear and parse. But not sure whether it'd be worth.


Takashi