Re: [PATCH nf] netfilter: nfnetlink_queue: unclone skb before writing NFQA_L2HDR

From: Florian Westphal

Date: Sat Nov 07 2026 - 11:34:41 EST


Tamaki Yanagawa <ty@xxxxxxxxx> wrote:
> nfqa_parse_bridge() copies the NFQA_L2HDR attribute over the mac header
> of the queued skb in place. Bridge flooding queues clones that share
> their data with the copies sent to the other ports, so the rewritten
> header also shows up on frames that never went through the queue, and
> is changed while those may already be in transmission. Unclone the skb
> before the copy, as nfqnl_mangle() does for NFQA_PAYLOAD via
> skb_ensure_writable().

Can you explain in changelog why full unclone is needed rather than
skb_ensure_writable()?