Re: [PATCH] hwmon: (nct6683) Remove the 32 mV voltage scale

[Guenter Roeck]

On Sat, Nov 07, 2026 at 04:06:19PM +0100, Tomasz Bojanowski wrote:
> in_from_reg() is meant to scale the VCC, VSB, AVSB and VBAT sources
> by 32 mV, but show_in_reg() passes it the monitor channel of the first
> three voltage sensors instead of the source of the sensor shown. The
> 32 mV case therefore never matches, and all voltages have been scaled
> by 16 mV since commit 41082d66bfd6 ("hwmon: Driver for NCT6683D").
> 
> According to the datasheet, there is no 32 mV LSB. On an MSI MAG
> B850M MORTAR WIFI (NCT6687D, customer ID 0x20d), VCC reads 3.31 V,
> VSB and AVSB 3.34 V and VBAT 3.10 V with 16 mV. With 32 mV they would
> read 6.6 V, 6.7 V and 6.2 V.
> 
> Drop the source argument and the 32 mV case. No functional change.
> 
> Link: https://lore.kernel.org/linux-hwmon/20261106144247.30507-1-tomasz@xxxxxxxxxxxxx/
> Signed-off-by: Tomasz Bojanowski <tomasz@xxxxxxxxxxxxx>

Applied.

Thanks,
Guenter