[PATCH v2] usb: musb: ux500: Fix transceiver leak in ux500_musb_init()
From: Wentao Liang
Date: Sat Nov 07 2026 - 11:47:48 EST
ux500_musb_init() takes a reference on the USB2 transceiver with
usb_get_phy() and stores it in musb->xceiv. If the following
usb_register_notifier() fails, the function returns without releasing
that reference.
The reference is only dropped in ux500_musb_exit(), and that callback is
not reached on this path: musb_init_controller() jumps straight to its
fail1 label when musb_platform_init() returns an error, while
musb_platform_exit() is only called from the fail2 path. The reference is
therefore leaked.
Put the transceiver on the notifier registration failure path. The
notifier itself does not need to be unregistered, since
usb_register_notifier() failed and never added it to the chain.
The bug was found with a static analysis tool; the candidate was then
audited and the fix written with the help of DeepSeek-V4.1-Flash and
GPT-6.1-Sol, and the result was checked by hand before submission.
Fixes: 0135522c4898 ("usb: musb: ux500: add otg notifier support")
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/all/20260916165055.2085246-1-vulab@xxxxxxxxxxx/
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
---
Changes in v2:
- Do not add the Assisted-by trailer: current checkpatch.pl reports it as a
non-standard signature, and Documentation/process/generated-content.rst
asks for the tooling to be described in the changelog, which the commit
message now does. Say the word if you would rather have the trailer and
I will add it back.
- Explain why musb_platform_exit() is not reached on this path, so the added
usb_put_phy() cannot double-put.
- Code unchanged from v1, so Linus's Reviewed-by is kept.
- Sorry it took me this long to come back, and sorry for the extra work of
chasing it.
drivers/usb/musb/ux500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 8c2a43d992f5..14c5e986937e 100644
--- a/drivers/usb/musb/ux500.c
+++ b/drivers/usb/musb/ux500.c
@@ -155,6 +155,7 @@ static int ux500_musb_init(struct musb *musb)
status = usb_register_notifier(musb->xceiv, &musb->nb);
if (status < 0) {
dev_dbg(musb->controller, "notification register failed\n");
+ usb_put_phy(musb->xceiv);
return status;
}
--
2.34.1