Re: [PATCH v2] iio: adc: ad4134: Fix duplicate data_read mux state request

[Jonathan Cameron]

On Thu, 5 Nov 2026 14:18:46 +0100
Joshua Crofts <crofts@xxxxxxxxxx> wrote:

> On Thu,  5 Nov 2026 11:31:20 +0800
> Chen Ni <nichen@xxxxxxxxxxx> wrote:
> 
> > devm_mux_state_get() is called twice in a row. The second call's result
> > is stored directly into st->mux_st[AD4134_DOUT0_INPUT] without error
> > checking, and then immediately overwritten by the first call's result.
> > 
> > Remove the duplicate call and check the return value before saving the
> > state.
> > 
> > Fixes: f12ecb3e147b ("iio: adc: ad4134: Support SPI 4-wire mode")
> > Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>  
> 
> Ideally your Signed-off-by tag should be the last one in the tag
> block. No need to resend however, this can be tweaked when applying.
> 
Applied but with fixes tag dropped. Those aren't stable until
a series has gone upstream and I've long given up on trying
to fix them up as the tree evolves.

I tweaked the ordering though I'll note I normally don't bother
too much on this as any review tags that come in after the
new posting go after the sign off anyway so it's a subtle distinction
that I'm not sure matters in practice!

Marcelo, this one looks obviously right but please take a look
just to be sure.

Jonathan